Enabling RuntimeEventSource in NativeAOT #85424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFor a CI check
|
davmason
reviewed
Apr 26, 2023
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/CounterPayload.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs
Show resolved
Hide resolved
This was referenced Apr 27, 2023
jkotas
reviewed
Apr 27, 2023
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 27, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Assembly.NativeAot.cs
Outdated
Show resolved
Hide resolved
agocke
reviewed
May 2, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Exception.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Exception.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
LakshanF
force-pushed
the
EnableCountersInEventPipe
branch
from
df98b45
to
9c204cd
Compare
…LR exceptioncount fix
agocke
requested changes
May 9, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Assembly.NativeAot.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
MichalStrehovsky
requested changes
May 10, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/GC.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Assembly.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
…tion/Assembly.NativeAot.cs Co-authored-by: Michal Strehovský <[email protected]>
ghost
removed
the
needs-author-action
jkotas
reviewed
May 10, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
MichalStrehovsky
approved these changes
May 11, 2023
Comment on lines
+120
to
+122
| // track count for metrics | ||
| if (isFirstFrame && !isFirstRethrowFrame) | ||
| Interlocked.Increment(ref s_exceptionCount); |
There was a problem hiding this comment.
I'm going to assume this matches how CoreCLR counts these wrt rethrow or ExceptionDispatchInfo.Throw.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuntimeEventSourcewasn't enabled in NativeAOT due to not being initialized whenEventSourceEnabledis set, missing metadata on critical payload types blocking reflection of these inEventSource.Added a module initializer to Initialize
RuntimeEventSourceifEventSourceEnabledis set, made the required types visible to reflection, and also enabled some missing counters inNativeAOT.